addCommas (v3)

Revision 3 of this benchmark created by Ryan Sullivan on

Description

addCommas is a simple script to add commas at every 3 digits from the right.

'Mine' was originally written by me in 2008. It only supports numbers (no strings) up to five digits (not including scale); six digit numbers will not have commas. See revision 2 for my updated solution that supports strings and numbers, including numbers in scientific notation.

'Theirs' comes from mredkj.com, variations of which I have seen all over.

Test runner

Ready to run.

Testing in
TestOps/sec
Mine
var addCommas = function(n) {
 var s = n.toFixed(2).replace('.00', '');
 var digits = (Math.floor(n) + '').length;
 for (var i = 0, j = 0, mod = digits % 3; i < digits; i++) {
  if (i == 0 || i % 3 != mod) {
   continue;
  }
  s = s.substr(0, i + j) + ',' + s.substr(i + j);
  j++;
 }
 return s;
};
addCommas(333000000000000000000) // 3.33e20
ready
Theirs
function addCommas(nStr) {
 nStr += '';
 x = nStr.split('.');
 x1 = x[0];
 x2 = x.length > 1 ? '.' + x[1] : '';
 var rgx = /(\d+)(\d{3})/;
 while (rgx.test(x1)) {
  x1 = x1.replace(rgx, '$1' + ',' + '$2');
 }
 return x1 + x2;
}
addCommas(333000000000000000000) // 3.33e20
ready

Revisions

You can edit these tests or add more tests to this page by appending /edit to the URL.

  • Revision 1: published by Ryan Sullivan on
  • Revision 2: published by Ryan Sullivan on
  • Revision 3: published by Ryan Sullivan on
  • Revision 9: published by Scott Sauyet on
  • Revision 10: published by dexbol on